Skip to content

[mono] Fix swizzle_mask type#107460

Merged
lewing merged 1 commit intodotnet:mainfrom
radekdoulik:pr-fix-swizzle-mask
Sep 6, 2024
Merged

[mono] Fix swizzle_mask type#107460
lewing merged 1 commit intodotnet:mainfrom
radekdoulik:pr-fix-swizzle-mask

Conversation

@radekdoulik
Copy link
Member

That was catched by llvm debug asserts, the mask should be vector of 16x 1 byte integers

That was catched by llvm debug asserts, the mask should be vector of 16 int8
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @lambdageek, @steveisok
See info in area-owners.md if you want to be subscribed.

@lambdageek
Copy link
Member

Should we backport this? Do you know if the release LLVM generates bad code if the swizzle mask has the wrong type?

@lewing
Copy link
Member

lewing commented Sep 6, 2024

Should we backport this? Do you know if the release LLVM generates bad code if the swizzle mask has the wrong type?

I think we should probably backport all these llvm fixes to at least 9.0

@lewing lewing merged commit dc5dbab into dotnet:main Sep 6, 2024
@lewing
Copy link
Member

lewing commented Sep 10, 2024

/backport release/9.0

@lambdageek
Copy link
Member

/backport to release/9.0

@github-actions
Copy link
Contributor

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
That was catched by llvm debug asserts, the mask should be vector of 16 int8
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
That was catched by llvm debug asserts, the mask should be vector of 16 int8
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants