[release/9.0] ARM64-SVE: Delay free all ops within conditional select #107436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ARM64-SVE: Delay free all ops within conditional select * Fix comment * Add test header * don't delay prefUseOpNum * Fix FMA * Add assert checks for delay free * Merge embedded op build code * fix formatting * simplify assert * simplify FMA code * Add tests for 106867 * ARM64-SVE: Allow op inside conditionselect to be non HWintrinsic TEST_IMG: ubuntu/dotnet-build TEST_CMD: safe ./projects/dotnet/build-runtime.sh Jira: ENTLLT-7634 Change-Id: I337a291be6661f104fe90c7cdc27150eede43647 * Add Sve.IsSupported to tests * Add Sve.IsSupported to test * fix formatting * Revert "ARM64-SVE: Allow op inside conditionselect to be non HWintrinsic" * Revert "ARM64-SVE: Allow op inside conditionselect to be non HWintrinsic" * Revert "ARM64-SVE: Allow op inside conditionselect to be non HWintrinsic"
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
a74nh
approved these changes
Sep 6, 2024
Contributor
a74nh
left a comment
a74nh
left a comment
There was a problem hiding this comment.
Agreed, this needs adding. Using the same argument multiple times in a call could quite easily happen in customer code using SVE.
jeffschwMSFT
approved these changes
Sep 6, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
jeffschwMSFT
added
Servicing-approved
Contributor
Author
|
@carlossanlop, @ViktorHofer @ericstj - this is ready to merge. |
Member
|
FYI - You can also ask @jeffschwMSFT to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107036 to release/9.0
Customer Impact
This bug was found internally where we are trying to assign same register to source and destination for a SVE instruction that is prefixed by MOVPRFX instruction. As per spec, that is not allowed.
Regression
This is not a regression, but merely a newly discovered bug from our internal testing.
Testing
Added test cases that uncovered the problem and ran all the existing SVE tests under stress.
Risk
Low. This only affects certain SVE instructions that could have MOVPRFX as the prefix instruction and the fix avoid assign same register to the operands. Besides, SVE is an experimental feature for .NET 9.