Move pinned heap handle table from BaseDomain to AppDomain and make callers go through the AppDomain#107420
Merged
elinor-fung merged 2 commits intodotnet:mainfrom Sep 6, 2024
Merged
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @tommcdon |
Member
This should be fine. I believe the lifetimes are the same and EnC for static fields was on |
AaronRobinsonMSFT
approved these changes
Sep 5, 2024
jkotas
approved these changes
Sep 6, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…ke callers go through the `AppDomain` (dotnet#107420) - Move the pinned heap handle table to `AppDomain` - This does make the current use in the `GlobalLoaderAllocator` (went through `SystemDomain`) and in EnC adding a static field (went through `AppDomain`) use the same table. They have the same lifetime. - Move `GetLoaderAllocator` (it already always returns the global one), `IsStringInterned`, `GetOrInternString` functions from `BaseDomain` to `AppDomain`
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…ke callers go through the `AppDomain` (dotnet#107420) - Move the pinned heap handle table to `AppDomain` - This does make the current use in the `GlobalLoaderAllocator` (went through `SystemDomain`) and in EnC adding a static field (went through `AppDomain`) use the same table. They have the same lifetime. - Move `GetLoaderAllocator` (it already always returns the global one), `IsStringInterned`, `GetOrInternString` functions from `BaseDomain` to `AppDomain`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppDomainGlobalLoaderAllocator(went throughSystemDomain) and in EnC adding a static field (went throughAppDomain) use the same table.GetLoaderAllocator(it already always returns the global one),IsStringInterned,GetOrInternStringfunctions fromBaseDomaintoAppDomaincc @jkotas @AaronRobinsonMSFT