Make Module::LoadAssembly return Assembly instead of DomainAssembly#107411
Merged
elinor-fung merged 4 commits intodotnet:mainfrom Sep 6, 2024
Merged
Make Module::LoadAssembly return Assembly instead of DomainAssembly#107411elinor-fung merged 4 commits intodotnet:mainfrom
elinor-fung merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
jkotas
approved these changes
Sep 6, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…otnet#107411) - Switch `Module::LoadAssembly` to return `Assembly` instead of `DomainAssembly` - Remove unnecessary parameter on Module::GetAssemblyIfLoaded - Remove `AssemblySpec::LoadDomainAssembly` - make callers use `AssemblySpec::LoadAssembly` instead
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…otnet#107411) - Switch `Module::LoadAssembly` to return `Assembly` instead of `DomainAssembly` - Remove unnecessary parameter on Module::GetAssemblyIfLoaded - Remove `AssemblySpec::LoadDomainAssembly` - make callers use `AssemblySpec::LoadAssembly` instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module::LoadAssemblyto returnAssemblyinstead ofDomainAssemblyAssemblySpec::LoadDomainAssembly- make callers useAssemblySpec::LoadAssemblyinsteadJust slowly switching some things to Assembly so that DomainAssembly is less pervasive (and easier to eventually remove).
Contributes to #104590
cc @jkotas @AaronRobinsonMSFT