JIT: Track GC info accurately into epilogs in codegen #107283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle tailcall arguments which are consumed by the call node but remain live into the epilog - Handle return nodes which move the operand to the return registers which then should remain live into the epilog Fix dotnet#107137
ghost
added
the
area-CodeGen-coreclr
3 tasks
This was referenced Dec 2, 2024
Closed
3 tasks
3 tasks
Member
Author
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall @kunalspathak Diffs. Some 0-sized diffs when checking stack cookies as we no longer mark those IGs nogc because the GC info should be correct now. This is essentially removal of the workaround added in #105596. |
BruceForstall
approved these changes
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107137