[release/8.0-staging] [Mono AOT] Fix error when returning zero sized struct#107198
Merged
jkurdek merged 3 commits intorelease/8.0-stagingfrom Sep 9, 2024
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jkurdek
added
area-Codegen-AOT-mono
and removed
area-CodeGen-coreclr
This was referenced Aug 30, 2024
ivanpovazan
approved these changes
Sep 2, 2024
vitek-karas
approved these changes
Sep 2, 2024
jeffschwMSFT
approved these changes
Sep 2, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
rbhanda
added
Servicing-approved
Contributor
|
Friendly reminder that Code Complete for the October Release is September 9. If we want this fix to be included in that release, please merge this PR before that date. |
Contributor
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/ba-g the runtime failures seem to be coming from browser-wasm linux Release WasmBuildTests #106663 . The runtime-extra-platforms fails are unrelated. |
This was referenced Sep 11, 2024
alexyakunin
added a commit
to ActualLab/Fusion
that referenced
this pull request
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #106013 to release/8.0-staging
/cc @jkurdek
Customer Impact
Customer reported #103628
The scenario is to use an
AutoorSequentiallayout struct with no fields as a return value of a method. Mono AOT compiler will fail in that case (the compiler itself will fail). The only workaround is to change the struct to not be auto/sequential.This caused different compilation failures on both
ArgVTypeAsScalarandArgVTypeInRegcodepaths. Fix forArgVTypeAsScalarpath involved rounding up a struct to one byte when empty. This matches a behaviour of not specifying a layout attribute on the struct. (#103628) TheArgVTypeInRegproduces malformed LLVM-IR. The fix was to align types. (#106259)Regression
Testing
New CI regression test.
Risk
Low. Any potential issues which this fix could introduce would be for scenarios where the compiler failed previously.