[cdac] Make GetObjectData for arrays use canonical method table when getting the element type #106718
Conversation
…getting the element type
ghost
added
the
|
Tagging subscribers to this area: @tommcdon |
| data->ElementTypeHandle = element.Address; | ||
| data->ElementType = (uint)runtimeTypeSystemContract.GetSignatureCorElementType(element); | ||
|
|
||
| // Get the element type from the canonical method table - see MethodTable::GetArrayElementType for coreclr equivalent |
There was a problem hiding this comment.
@davidwrighton It came as a surprise to me that MethodTable::GetArrayElementType would return something different from MethodTable::GetArrayElementTypeHandle().GetSignatureCorElementType(). I don't know the implications (if any) of those two not matching - I'm not sure if this just expected or if it could be problematic in some way?
I see how we get there by using the object[] method table:
runtime/src/coreclr/vm/array.cpp
Lines 226 to 237 in 7cd266e
The only case I could figure out where this would happen is an array of a multi-dimensional or non-zero-based array - for example, ushort[][,]. The CorElementType of the element type handle (ushort[,]) is ELEMENT_TYPE_ARRAY in that case, which doesn't match ELEMENT_TYPE_CLASS of object[] .
There was a problem hiding this comment.
This is historic artifact of how arrays were represented in the past and fragile NGen.
It may be best to delete ArrayClass::m_ElementType field, GetArrayElementType methods, and replace their calls with GetArrayElementTypeHandle().GetSignatureCorElementType/GetVerifierCorElementType as appropriate.
There was a problem hiding this comment.
Ah, thanks. I'll look at doing that.
elinor-fung
requested review from
AaronRobinsonMSFT,
davidwrighton and
lambdageek
2 participants
When getting the element type for an array, cDAC was just getting the CorElementType of the element type handle. However, there are cases where that does not match the element type on the class for the array's canonical method table - for example, arrays of multi-dimensional or non-zero-based arrays. This changes the cDAC to use the canonical method table when getting the element type - matching the DAC (which uses
MethodTable::GetArrayElementType).