[release/9.0] Add NativeRuntimeEventSource metadata to NativeAot CoreLib#106713
Merged
jkotas merged 5 commits intorelease/9.0from Aug 22, 2024
Merged
[release/9.0] Add NativeRuntimeEventSource metadata to NativeAot CoreLib#106713jkotas merged 5 commits intorelease/9.0from
jkotas merged 5 commits intorelease/9.0from
Conversation
This is necessary to allow consumers to parse the payload. Delete unnecessary runtimeflavor argument of genRuntimeEventSources.py script. Fixes #105556
github-actions
bot
requested review from
MichalStrehovsky and
marek-safar
as code owners
ghost
added
the
needs-area-label
jeffschwMSFT
approved these changes
Aug 20, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review and then we can merge
Contributor
|
cc @dotnet/dotnet-diag |
jkotas
added
area-System.Threading
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @mangod9 |
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #106641 to release/9.0
/cc @jkotas
Customer Impact
Some event descriptions were missing in event source manifest on native AOT. It prevents these specific events from being parsed by diagnostic tools and other tracing consumers.
Regression
This was bug in a native AOT diagnostic work done during .NET 8. We found it thanks to additional tests.
Testing
Found by new test that is passing now
Risk
Low