Mark Encoding as nullable in StreamWriter's constructor#106658
Merged
jozkee merged 6 commits intodotnet:mainfrom Sep 16, 2024
Merged
Mark Encoding as nullable in StreamWriter's constructor#106658jozkee merged 6 commits intodotnet:mainfrom
jozkee merged 6 commits intodotnet:mainfrom
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
jozkee
reviewed
Aug 19, 2024
Member
There was a problem hiding this comment.
Can you please take into account #2376 (comment). I think we should align string overloads with the Stream ones as well as cover StreamReader, and update the tests accordingly.
adamsitnik
reviewed
Aug 20, 2024
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
Hi @stefannikolei !
Thank you for your contribution. Please update the reference file as well: https://github.com/dotnet/runtime/blob/9876ed1b72bb82018cdf18f0e8780c721cf806cd/src/libraries/System.Runtime/ref/System.Runtime.cs#L10752-L10755
Contributor
Author
|
I also changed the string based constructors and removed the checks for ArgumentNullException in the tests |
jozkee
approved these changes
Sep 3, 2024
src/libraries/System.Runtime/tests/System.IO.Tests/StreamWriter/StreamWriter.StringCtorTests.cs
Show resolved
Hide resolved
stefannikolei
force-pushed
the
streamwriter_constructor
branch
from
83a01fe to
4591bff
Compare
This was referenced Sep 3, 2024
Member
|
/ba-g #104340 (comment). |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* Mark Encoding as nullable in StreamWriter's constructor * Update reference file * Align string constructors with Stream * add explicit test for null as encoding
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Mark Encoding as nullable in StreamWriter's constructor * Update reference file * Align string constructors with Stream * add explicit test for null as encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106237