[release/8.0-staging] Fix logging formatting#106367
Merged
tarekgh merged 1 commit intodotnet:release/8.0-stagingfrom Aug 25, 2024
Merged
[release/8.0-staging] Fix logging formatting#106367tarekgh merged 1 commit intodotnet:release/8.0-stagingfrom
tarekgh merged 1 commit intodotnet:release/8.0-stagingfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
Member
Author
ericstj
approved these changes
Aug 13, 2024
rbhanda
added
Servicing-approved
Member
Author
|
@ergunr are you trying to communicate something on this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #106283 to release/8.0-dtaging
/cc @tarekgh
Customer Impact
Users of the .NET logging system may encounter incorrect log entries when attempting to log more than one collection argument. Instead of logging the individual values of the collection, the type name of the collection is logged. Examples of this issue can be found at #103338.
This is a regression in .NET 8.0
Details
We had some performance improvements in the logging formatting code that caused this regression.
Testing
Passed the regression tests and added more tests to cover the failing cases.
Risk
Low. This change only addresses the broken cases in the logging formatting code. It doesn't alter any logic; it simply ensures that collection formatting is corrected.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.