Add DiagnosticSource to CheckNonEventSourcesRunning #106337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
CC @davmason |
matouskozak
requested review from
antonfirsov,
mikelle-rogers,
tommcdon and
vitek-karas
vitek-karas
approved these changes
Aug 14, 2024
matouskozak
deleted the
add-DiagnosticSource-to-CheckNonEventSourcesRunning
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of
ActiveSourcesinSystem.Net(#103922) started causing failures whereMicrosoft-Diagnostics-DiagnosticSourceruns on iOS tests which wasn't expected. This PR addsMicrosoft-Diagnostics-DiagnosticSourceto theCheckNoEventSourcesRunningbuilt-inEventSourcelist so that it's no longer considered as running (suggested at #104881 (comment)).Should fix #104881