Workaround EventSource counters race condition in networking tests#106294
Merged
MihaZupan merged 2 commits intodotnet:mainfrom Aug 13, 2024
Merged
Workaround EventSource counters race condition in networking tests#106294MihaZupan merged 2 commits intodotnet:mainfrom
MihaZupan merged 2 commits intodotnet:mainfrom
Conversation
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 13, 2024
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106268
See #106268 (comment)
Since some
IncrementingPollingCounterdata may be dropped from the first reported increment, this change ensures that the background timer thread is running before executing the actual test code.Updated our Http and Security tests as those are the only ones using an
IncrementingPollingCounter.