Make {Try}GetAlternateLookup methods for Dictionary/HashSet instance instead of extensions#106107
Merged
stephentoub merged 1 commit intodotnet:mainfrom Aug 8, 2024
Merged
Conversation
stephentoub
added
the
NO-MERGE
ghost
added
|
Note regarding the |
1 similar comment
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
…hSet We made them extension methods instead of instance methods to avoid potential native code size bloat. But the ergonomics of using these without partial generic inference is a bit painful, and we've had reports that it makes them harder to understand. This moves them to be instance methods, and we'll measure the impact on code size to re-evaluate the decision.
stephentoub
force-pushed
the
movegetalternate
branch
from
3099df8 to
26e6c6e
Compare
This was referenced Aug 8, 2024
stephentoub
removed
the
NO-MERGE
stephentoub
changed the title
stephentoub
changed the title
Member
Author
|
Discussed offline with @jkotas, @MichalStrehovsky, @terrajobst, and @eiriktsarpalis. After gathering some data and discussing, it turns out that generic methods (whether or not on a generic type) don't have the same concerning effect on Native AOT code size as do non-generic methods on generic types. We've agreed to go ahead with this improvement. |
jkotas
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made them extension methods instead of instance methods to avoid potential native code size bloat. But the ergonomics of using these without partial generic inference is a bit painful, and we've had reports that it makes them harder to understand. This moves them to be instance methods, and we'll measure the impact on code size to re-evaluate the decision.