Bring back assert in fx_ver_t::parse#106050
Merged
elinor-fung merged 1 commit intodotnet:mainfrom Aug 14, 2024
Merged
Conversation
ghost
added
the
This was referenced Aug 7, 2024
agocke
approved these changes
Aug 14, 2024
Member
agocke
left a comment
agocke
left a comment
There was a problem hiding this comment.
Looks like this is fixed. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we got to what exactly might have been included in a bad order, but enough has changed (like
fx_ver_t::as_strthat the assert here no longer aborts.Fixes #68927
cc @dotnet/appmodel