Fix dump generation on background threads#105898
Merged
mikem8361 merged 1 commit intodotnet:release/8.0-stagingfrom Aug 6, 2024
Merged
Fix dump generation on background threads#105898mikem8361 merged 1 commit intodotnet:release/8.0-stagingfrom
mikem8361 merged 1 commit intodotnet:release/8.0-stagingfrom
Conversation
ghost
added
the
jeffschwMSFT
approved these changes
Aug 2, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
hoyosjs
approved these changes
Aug 5, 2024
carlossanlop
added
Servicing-approved
Contributor
|
Approved by Tactics via email. |
Contributor
Author
|
Do I merge this PR or do you Carl? |
Contributor
The honor of pressing the squash and merge button is granted to the PR owner (or any area owner) if all requirements are met. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #103000
PR from main: #105830
Customer Impact
External dev found that dumps were not be generated for unhandled exceptions on background threads.
Testing
A simple test case was provided and used to verify this fix.
Risk
Very low. A couple of lines of code in the termination path for unhandled exceptions. This is Windows only.