JIT ARM64-SVE: add missing test coverage for invalid immediate (#104809)#105677
JIT ARM64-SVE: add missing test coverage for invalid immediate (#104809)#105677amanasifkhalid merged 2 commits intodotnet:mainfrom
Conversation
…y32BitElementCount_{long,uint} tests
|
Stress testing for all of the relevant APIs passes successfully now. The issue with |
Yes, because the invalid |
a74nh
left a comment
There was a problem hiding this comment.
LGTM, assuming that all the templates missing if (!succeeded) have now been fixed.
|
@mikabl-arm : could you add |
There was a problem hiding this comment.
LGTM, I'm assuming you ran the unoptimized tests too (HardwareIntrinsics_Arm_r.dll), right? @mikabl-arm
Just verified, unoptimized tests pass as well. |
|
/ba-g blocked by timeouts, dotnet install failures |
Fixes #104809 .
SVE APIs which tests were affected:
DotProductBySelectedScalarSaturatingDecrementBy*SaturatingIncrementBy*ShiftRightArithmeticForDivideDuplicateSelectedScalarToVectorAll tests
other thanpass successfully.Sve_SaturatingIncrementBy32BitElementCount_longandSve_SaturatingIncrementBy32BitElementCount_uintI believeSaturatingIncrementBy32BitElementCounthas a bug which used to be silently ignored before and began to manifest itself now after the testing was fixed. @a74nh