Use correct IL offset when reporting dataflow warnings for return statements #105661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
sbomer
force-pushed
the
trackReturnOffset
branch
from
eafaa6d to
0447405
Compare
3 tasks
sbomer
commented
Jul 30, 2024
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/MethodBodyScanner.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 30, 2024
Member
Author
am11
added
linkable-framework
MichalStrehovsky
approved these changes
Aug 7, 2024
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/MethodBodyScanner.cs
Outdated
Show resolved
Hide resolved
…thodBodyScanner.cs Co-authored-by: Michal Strehovský <[email protected]>
This was referenced Aug 7, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of merging all returned values into a single return value and reporting warnings based on that, report warnings per return statement, using the IL offset at that point. This allows us to fix the message origin to match the IL offset of each individual return statement, so we can remove a workaround from the pattern store.
Fixes dotnet/linker#2778
@dotnet/appmodel PTAL