Skip to content

[infra] Disable broken linux_musl Mono AOT cross-compiler jobs in .NET 8#105549

Merged
ivanpovazan merged 1 commit intodotnet:release/8.0-stagingfrom
ivanpovazan:release/8.0-staging
Jul 26, 2024
Merged

[infra] Disable broken linux_musl Mono AOT cross-compiler jobs in .NET 8#105549
ivanpovazan merged 1 commit intodotnet:release/8.0-stagingfrom
ivanpovazan:release/8.0-staging

Conversation

@ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Jul 26, 2024 •
edited
Loading

Description

After merging #105460 we discovered that both:

  • linux_musl-x64 release CrossAOT_Mono crossaot and
  • linux_musl-arm64 release CrossAOT_Mono crossaot

are broken jobs i.e., they never produced cross compiler packages.

Starting: Prepare job-specific intermediate artifacts subdirectory (linux_musl_x64)
==============================================================================
Task         : Copy files
Description  : Copy files from a source folder to a target folder using patterns matching file paths (not folder paths)
Version      : 2.238.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/copy-files
==============================================================================
found 2 files
Cleaning target folder: /__w/1/a/IntermediateArtifacts/MonoRuntimePacks
Copying /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoTargets.Sdk.8.0.8.nupkg to /__w/1/a/IntermediateArtifacts/MonoRuntimePacks/Shipping/Microsoft.NET.Runtime.MonoTargets.Sdk.8.0.8.nupkg
Copying /__w/1/s/artifacts/packages/Release/Shipping/symbols/Microsoft.NET.Runtime.MonoTargets.Sdk.8.0.8.symbols.nupkg to /__w/1/a/IntermediateArtifacts/MonoRuntimePacks/Shipping/symbols/Microsoft.NET.Runtime.MonoTargets.Sdk.8.0.8.symbols.nupkg
Finishing: Prepare job-specific intermediate artifacts subdirectory (linux_musl_x64)

The only package they did publish is the one we disabled in #105460 so the jobs are now failing in the official build (https://dev.azure.com/dnceng/internal/_build/results?buildId=2502592&view=logs&j=a8ec8236-0fa3-5615-96d9-fad9a048e3ab&t=7c71d56b-eebb-5a41-c166-16134978d78b&l=9).

By looking back in time (to Oct-2023) these jobs never worked properly and since we did not receive any customer complaints we are just disabling them for .NET 8.

NOTE

FWIW this is properly fixed in .NET9 via: 7f81848 but was not backported.

@ivanpovazan ivanpovazan added this to the 8.0.9 milestone Jul 26, 2024
@ivanpovazan ivanpovazan self-assigned this Jul 26, 2024
@ivanpovazan
Copy link
Member Author

ivanpovazan commented Jul 26, 2024

@carlossanlop Could you please take a look?
This is a CI fix that is needed to get the official builds green again.

@carlossanlop
Copy link
Contributor

carlossanlop commented Jul 26, 2024 •
edited
Loading

FWIW this is properly fixed in .NET9 via: 7f81848 but was not backported

So are we planning to backport this?

carlossanlop
carlossanlop approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell-mode, approved.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jul 26, 2024
@ivanpovazan ivanpovazan merged commit 1b7910d into dotnet:release/8.0-staging Jul 26, 2024
@ivanpovazan
Copy link
Member Author

ivanpovazan commented Jul 26, 2024

FWIW this is properly fixed in .NET9 via: 7f81848 but was not backported

So are we planning to backport this?

I am not sure, my understand is that in .NET 8 it was a niche feature.

@directhex what do you think?

@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
@rbhanda rbhanda modified the milestones: 8.0.9, 8.0.10 Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@directhex directhex Awaiting requested review from directhex

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivanpovazan ivanpovazan

Labels

area-Infrastructure-mono Servicing-approved Approved for servicing release

Projects

None yet

Milestone

8.0.10

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanpovazan @carlossanlop @rbhanda