Conversation
remove local logging undo line
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc |
Maoni0
added
the
NO-MERGE
|
please do not merge. I also have some cleanup stuff that I'll include. |
Maoni0
left a comment
Maoni0
left a comment
There was a problem hiding this comment.
LGTM. I actually don't have time to do the cleanup changes I wanted to add due to my OOF. but could you please also add a change that rename the DYNAMIC_HEAP_COUNT define to DYNAMIC_ADAPTATION_TO_APP? since DATAS (and I imagine in the future we'd want to adapt to other things other than size) is not just limited to heap count changes.
|
Can we also remove this obsolete comment? // REGIONS TODO: we should reserve enough space at the end of what we reserved that's
// big enough to accommodate if we were to materialize all the GC bookkeeping datastructures.
// We only need to commit what we use and just need to commit more instead of having to
// relocate the existing table and then calling copy_brick_card_table.
// Right now all the non mark array portions are commmitted since I'm calling make_card_table
// on the whole range. This can be committed as needed. |
markples
removed
the
NO-MERGE
markples
force-pushed
the
94175_cleanup
branch
from
97114c5 to
347486d
Compare
markples
force-pushed
the
94175_cleanup
branch
from
476bc1c to
0c4a3a9
Compare
| heap_budget_in_region_units[i][large_free_region] = 0; | ||
| } | ||
|
|
||
| dprintf (1, ("moved %2zd regions (%8zd) to decommit based on time", num_decommit_regions_by_time, size_decommit_regions_by_time)); |
There was a problem hiding this comment.
dprintf(REGIONS_LOG)
| #ifdef USE_REGIONS | ||
| if (regions_range) | ||
| { | ||
| // REGIONS TODO: we should reserve enough space at the end of what we reserved that's |
There was a problem hiding this comment.
not obsolete - not reserving a range for this today
(see make_card_table)
|
add "no functional changes" to title and wait for regions work ("region units" changes won't be needed after that) |
Maoni0
left a comment
Maoni0
left a comment
There was a problem hiding this comment.
other than the few trivial things you took notes off, the rest LGTM!
|
@Maoni0, what would you like to have happen with this PR? Do you want to address your remaining comments or do you want to close this? Thanks. |
|
I'll close. no time for this currently. |
4 participants
transfer_regionstotransfer_regions_fromdprintfinget_region_infodprintfnearer to the relevant codedprintfs