[browser] avoid OOM in RentingGiganticArraySucceedsOrOOMs #105246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-memory |
Member
|
Should we disable this on 32-bit instead of on browser? |
Member
Author
I don't know if there is another 32bit target still supported ? Anyway, they probably don't have problems with growing WASM linear memory and we don't see anything else to fail. |
kg
approved these changes
Jul 22, 2024
maraf
approved these changes
Jul 22, 2024
Member
Author
|
/ba-g CI failure is unrelated iOS timeout |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the browser, allocating 1.8gb on 32bit address space is no fun.
Especially with all the preceding and following allocations in the same test suite.
In MT build, it also needs to grow the size of linear memory via UI thread and synchronize it to all threads.
Contributes to #102040
Contributes to #102195