[release/8.0-staging] For transition profiler callbacks, always load the thread#105200
Merged
jkoritzinsky merged 3 commits intorelease/8.0-stagingfrom Aug 12, 2024
Merged
Conversation
Also, add tests for profiler callbacks on a new thread to the runtime
ghost
added
the
Contributor
|
Tagging subscribers to this area: @tommcdon |
AaronRobinsonMSFT
approved these changes
Jul 22, 2024
jkoritzinsky
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Jul 22, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
rbhanda
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #105104 to release/8.0-staging
/cc @jkoritzinsky
Customer Impact
Using a profiler for reverse P/Invokes could result in a null-reference exception from the runtime. This PR fixes the problem by loading a non-null correct value for the parameter.
Regression
Introduced in #69761
Testing
Added more profiler unit tests to validate the scenario.
Risk
Low risk, we've validated that the scenario works and the fix is targeted to the failing scenario.