Add libicu74 as a known ICU version#104754
Merged
jkoritzinsky merged 1 commit intomainfrom Jul 17, 2024
Merged
Conversation
Ubuntu 24.04 ships ICU v74 as the libicu74 package, so we need to add it as a known version. Contributes to dotnet/sdk#40506 This does not affect source-build. Canonical defines their own deb packages and they do not use the runtime-deps package.
Member
Author
|
/backport to release/8.0-staging |
Member
Author
|
/backport to release/6.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9898509112 |
Contributor
|
Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/9898510461 |
This was referenced Jul 11, 2024
baronfel
approved these changes
Jul 11, 2024
Member
baronfel
left a comment
baronfel
left a comment
There was a problem hiding this comment.
Thanks for hopping on this so quickly!
jkoritzinsky
added
the
NO-MERGE
Member
Author
|
Marking as no-merge until questions in dotnet/sdk#40506 are resolved. |
Member
Author
|
I spoke offline with Rich. We'll merge this in now and make an issue for next steps to better guide users to the best experience. |
jkoritzinsky
removed
the
NO-MERGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu 24.04 ships ICU v74 as the libicu74 package, so we need to add it as a known version.
Contributes to dotnet/sdk#40506
This does not affect source-build. Canonical defines their own deb packages and they do not use the runtime-deps package.