Make CertLoader reject duplicate attributes#104344
Merged
bartonjs merged 3 commits intodotnet:mainfrom Jul 4, 2024
Merged
Conversation
The new Pkcs12 loader will now reject duplicate attributes, either as multiple attribute sets, or a set with multiple values. The LoaderLimits type gains an option to disable this filter, but as of now it is not being made into public API (though the tests show how to get at it anyways, by the cloning behavior on DangerousNoLimits). This change also fixes the over-filtering of the MachineKey attribute, and adds tests for how that behaves under DefaultKeySet.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced Jul 3, 2024
vcsjones
reviewed
Jul 3, 2024
...ies/Common/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.Pkcs12.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Jul 3, 2024
...ies/Common/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.Pkcs12.cs
Outdated
Show resolved
Hide resolved
vcsjones
approved these changes
Jul 3, 2024
bartonjs
added
cryptographic-docs-impact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Pkcs12 loader will now reject duplicate attributes, either as multiple attribute sets, or a set with multiple values.
The LoaderLimits type gains an option to disable this filter, but as of now it is not being made into public API (though the tests show how to get at it anyways, by the cloning behavior on DangerousNoLimits).
This change also fixes the over-filtering of the MachineKey attribute, and adds tests for how that behaves under DefaultKeySet.
Fixes #103924