[NativeAOT] WindowsUse RtlDllShutdownInProgress to detect process shutdown#104318
Merged
jkotas merged 1 commit intodotnet:mainfrom Jul 2, 2024
Merged
[NativeAOT] WindowsUse RtlDllShutdownInProgress to detect process shutdown#104318jkotas merged 1 commit intodotnet:mainfrom
jkotas merged 1 commit intodotnet:mainfrom
Conversation
shutdown Port dotnet#103877 to Native AOT. This is fixing intermittent shutdown hangs that can observed by running the tests attached to dotnet#103877.
ghost
added
the
jkotas
changed the title
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
commented
Jul 2, 2024
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| #include "common.h" | ||
| #ifdef HOST_WINDOWS | ||
| #include <windows.h> |
Member
Author
There was a problem hiding this comment.
The PAL just gets into way in the complicated interactions that this requires, putting the code under ifdef is a lot simpler.
Member
Author
|
cc @agocke I think that the intermittent shutdown deadlocks that this is fixing are more likely to be hit by naot libraries mode that is used by some of the high-scale workloads. If we get reports of shutdown hangs from production, this fix can be backported. |
davidwrighton
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #103877 to Native AOT. This is fixing intermittent shutdown hangs that can observed by running the tests attached to #103877.