Have morph normalize patterns to GT_NEG and GT_NOT #104214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Jul 1, 2024
Open
This was referenced Jul 1, 2024
Member
Author
|
CC. @dotnet/jit-contrib this should be ready for review. This ensures we get a consistent view of GT_NEG and GT_NOT operations for both scalar and SIMD nodes. It minorly improves codegen and gets us better/more consistent output in several scenarios. |
kunalspathak
approved these changes
Jul 3, 2024
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
seems more of the code wins are coming from one method in particular:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we get a consistent view of NEG and NOT nodes in HIR, which allows other optimizations to more reliably kick in.