Skip to content

Conversation

@vcsjones
Copy link
Member

This obsoletes X.509 loading APIs that

  • Take raw bytes
  • Take a path to a file

This also changes product code to use the new X509CertificateLoader. Unit tests currently suppress the new obsoletion diagnostic. There are literally 1000s of unit tests changes that need to be updated to use the new loader. This will be done in a subsequent pull request, project-by-project, to make review easier, and to keep this pull request focused on shipping code.

Contributes to #91763.

@ghost
Copy link

ghost commented Jun 28, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost

This comment was marked as duplicate.

@vcsjones vcsjones added this to the 9.0.0 milestone Jun 28, 2024
@vcsjones vcsjones requested a review from bartonjs July 2, 2024 16:49
@vcsjones vcsjones added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Jul 5, 2024
@vcsjones vcsjones merged commit 02bd1da into dotnet:main Jul 5, 2024
@vcsjones vcsjones deleted the x509-obs-ctor branch July 5, 2024 17:37
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jul 5, 2024

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jul 5, 2024
@vcsjones
Copy link
Member Author

vcsjones commented Jul 5, 2024

Doc: dotnet/docs#41662

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a previous release. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet new-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants