-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Obsolete X509Certificate{2} constructors and X509Certificate2Collection.Import #104165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
bartonjs
reviewed
Jun 28, 2024
src/libraries/System.Security.Cryptography.Pkcs/src/System.Security.Cryptography.Pkcs.csproj
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 28, 2024
src/libraries/System.Security.Cryptography.Pkcs/src/System.Security.Cryptography.Pkcs.csproj
Show resolved
Hide resolved
bartonjs
reviewed
Jun 28, 2024
bartonjs
reviewed
Jun 28, 2024
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 28, 2024
...raphy/src/System/Security/Cryptography/X509Certificates/OpenSslCertificateAssetDownloader.cs
Show resolved
Hide resolved
vcsjones
commented
Jun 29, 2024
...ies/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/KeyInfoX509Data.cs
Show resolved
Hide resolved
vcsjones
commented
Jun 29, 2024
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Jul 5, 2024
Contributor
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
Member
Author
|
Doc: dotnet/docs#41662 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Security
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
new-api-needs-documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obsoletes X.509 loading APIs that
This also changes product code to use the new
X509CertificateLoader. Unit tests currently suppress the new obsoletion diagnostic. There are literally 1000s of unit tests changes that need to be updated to use the new loader. This will be done in a subsequent pull request, project-by-project, to make review easier, and to keep this pull request focused on shipping code.Contributes to #91763.