Add regression test for assembly origin for event marking#102836
Merged
jtschuster merged 3 commits intodotnet:mainfrom May 30, 2024
Merged
Add regression test for assembly origin for event marking#102836jtschuster merged 3 commits intodotnet:mainfrom
jtschuster merged 3 commits intodotnet:mainfrom
Conversation
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
linkable-framework
jtschuster
added
area-Tools-ILLink
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
sbomer
approved these changes
May 29, 2024
src/tools/illink/test/Mono.Linker.Tests.Cases/Attributes/AssemblyAttributeAccessesMembers.cs
Outdated
Show resolved
Hide resolved
src/tools/illink/test/Mono.Linker.Tests.Cases/Attributes/AssemblyAttributeAccessesMembers.cs
Outdated
Show resolved
Hide resolved
src/tools/illink/test/Mono.Linker.Tests.Cases/Attributes/AssemblyAttributeAccessesMembers.cs
Outdated
Show resolved
Hide resolved
src/tools/illink/test/Mono.Linker.Tests.Cases/Attributes/AssemblyAttributeAccessesMembers.cs
Outdated
Show resolved
Hide resolved
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
) Adds a regression test for the issue that was fixed in dotnet#102613. The assembly level attribute marks the members on the referenced type, and the assembly is the MessageOrigin for the marking. I confirmed this fails with before dotnet#102613.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for the issue that was fixed in #102613.
The assembly level attribute marks the members on the referenced type, and the assembly is the MessageOrigin for the marking.
I confirmed this fails with before #102613.