Backport #102613 to preview 5#102778
Merged
agocke merged 2 commits intodotnet:release/9.0-preview5from May 29, 2024
Merged
Conversation
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
lewing
approved these changes
May 28, 2024
lewing
reviewed
May 28, 2024
Member
|
/ba-g wbt failures are expected due to downlevel versions |
sbomer
approved these changes
May 29, 2024
agocke
added
Servicing-approved
Member
|
Pushing this through due to time shortage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug made it into preview 5 right before the snap, and the fix didn't make it in time. It's blocking runtime flow to sdk in dotnet/sdk#41166.
See #102613 for additional context.
Customer Impact:
#102528 added an assumption/assertion that didn't consider marking that originates from assembly level attributes. This assumption leads to an invalid cast exception in Blazor AOT trimming tests in the sdk.
Testing:
This isn't tested in runtime, but the original PR fixed the tests in SDK during flow from runtime's main to sdk's main. Since it was a hotfix, no tests have yet been added that exercise this code path.
Risk:
Minimal. This reverts the assertion and returns to behavior that was previously in the .NET 8 release.