Socket.DontFragment can't be set on IPv6 DualMode sockets#102700
Socket.DontFragment can't be set on IPv6 DualMode sockets#102700antonfirsov merged 5 commits intodotnet:mainfrom
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs
Outdated
Show resolved
Hide resolved
| Assert.Throws<ArgumentNullException>(() => Socket.CancelConnectAsync(null)); | ||
| } | ||
|
|
||
| // MacOS doesn't support setting don't-fragment (DF) bit |
There was a problem hiding this comment.
It is supported actually since MacOSX 11.0 (Big Sur)+. We should be more specific with the filter condition. Can you check on what pipelines did it fail originally? FYI our other DontFragment test only filters out iOS+tvOS+Catalyst, but not sure if it's correct:
There was a problem hiding this comment.
The failing configurations are :
net9.0-osx-Debug-x64-coreclr_release-OSX.1200.Amd64.Open
net9.0-osx-Debug-x64-Mono_Minijit_Debug-OSX.1200.Amd64.Open
System.Net.Sockets.SocketException : Invalid argument
at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, Boolean disconnectOnFailure, String callerName) in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3737
at System.Net.Sockets.Socket.UpdateStatusAfterSocketOptionErrorAndThrowException(SocketError error, String callerName) in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3728
at System.Net.Sockets.Socket.SetSocketOption(SocketOptionLevel optionLevel, SocketOptionName optionName, Int32 optionValue, Boolean silent) in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3466
at System.Net.Sockets.Socket.SetSocketOption(SocketOptionLevel optionLevel, SocketOptionName optionName, Int32 optionValue) in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 1966
at System.Net.Sockets.Socket.set_DontFragment(Boolean value) in /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 653
at System.Net.Sockets.Tests.ArgumentValidation.CanSetDontFragment_OnIPV6Address_DualModeSocket() in /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs:line 1166
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args) in /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs:line 36
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs:line 57
There was a problem hiding this comment.
That is weird since those machines are running on 12.7.4. Regardless, I think this PR changes things for the better so I think we can merge this and open a tracking issue for the MacOS problem.
There was a problem hiding this comment.
macOS did not support DF for long time at all. It does not surprise me that it does not work on dual mode socket. FreeBSD (and others) may be on the same boat e.g. it may be better to make this to running only on platfoprms where we know it works instead of excluding macOS
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
@wfurt any objection to merging this?
|
I think it OK. small suggestion for the test. |
5 participants
Fixes #76410