Repository navigation
CodeVersionManager updates - #102298
Merged
AaronRobinsonMSFT merged 8 commits intoMay 22, 2024
Merged
CodeVersionManager updates#102298
CodeVersionManager updates#102298Conversation
Remove the dictionary from the CodeVersionManager and instead store the data directly on the MethodDesc. Pass allocator for codedata allocation.
Move the state data structure to typical MethodDesc instance.
AaronRobinsonMSFT
force-pushed
the
codeversion_updates
branch
from
May 16, 2024 04:25
1a2d0b7 to
a9a6ae5
Compare
Member
Author
Member
Author
|
No regressions found running the diagnostic tests locally with this change. |
jkotas
reviewed
May 17, 2024
davidwrighton
left a comment
davidwrighton
left a comment
Member
There was a problem hiding this comment.
This looks good, but as I discussed offline, before you checkin, I'd like to know what the impact is on memory consumption.
Member
Author
|
I used https://github.com/dotnet/eShop to collect memory usage numbers. I focused on the Catalog service. Overall runtime memory consumption increased by 811k with these changes. The complexity reduction for the cDAC is a substantial and @davidwrighton is working on using this new data hanging off the Main: With changes: |
davidwrighton
requested changes
May 21, 2024
davidwrighton
left a comment
davidwrighton
left a comment
Member
There was a problem hiding this comment.
Please use the NoThrow variant of the allocator
davidwrighton
approved these changes
May 21, 2024
Member
|
Great, now to integrate this with #101580 |
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
* Code Versioning - move native code versioning state Remove the dictionary from the CodeVersionManager and instead store the data directly on the MethodDesc. * Remove dictionary for IL version states. Remove the dictionary from the CodeVersionManager and instead store the data in the Module.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Code Versioning - move native code versioning state Remove the dictionary from the CodeVersionManager and instead store the data directly on the MethodDesc. * Remove dictionary for IL version states. Remove the dictionary from the CodeVersionManager and instead store the data in the Module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove maps on
CodeVersionManagerand places native version data on theMethodDescand the IL version data on theModule. There is no functional change intended here. The change is simply to remove two currently unnecessary map data structures. The contract API has change slightly but remains semantically the same.This is a simplification for the cDAC effort.