Small followup to Use QueueUserAPC2 for EE suspension on CoreCLR win-arm64#102021
Merged
VSadov merged 1 commit intodotnet:mainfrom May 8, 2024
Merged
Small followup to Use QueueUserAPC2 for EE suspension on CoreCLR win-arm64#102021VSadov merged 1 commit intodotnet:mainfrom
VSadov merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @mangod9 |
Member
Author
|
I missed that too. Merged, and then realized we skipped an indirection. |
Member
Author
|
It would have failed in a CET-enabled run. |
Member
we do have a CET enabled pipeline, but don't run it on a regular basis. @eduardo-vp, perhaps we should look into running it as extra-platforms suite. |
Member
Author
I think running once in a while may be sufficient. This is not something that is frequently touched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #101891
RtlGetReturnAddressHijackTargetneeds to be invoked. It is not the hijack address, it is the provider of the address.