Handle missing HTTP3 error cases by rzikm · Pull Request #101923 · dotnet/runtime

rzikm · 2024-05-06T15:08:47Z

Closes #89097.
Fixes #102202.

…tocol errors in test

…tion

rzikm · 2024-05-06T15:09:32Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2024-05-06T15:09:40Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP · 2024-05-15T13:46:55Z

#102202 might be related.

rzikm · 2024-05-15T15:51:02Z

#102202 might be related.

I would prefer to handle this one separately, it does not look trivial and the callstack for that one is very weird

client-1  | --- End of stack trace from previous location ---
client-1  |    at System.Net.Quic.ResettableValueTaskSource.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token) in /_/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ResettableValueTaskSource.cs:line 251
client-1  |    at System.Net.Http.Http3RequestStream.ReadFrameEnvelopeAsync(CancellationToken cancellationToken) in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 803
client-1  |    at System.Net.Quic.QuicStream.WriteAsync(ReadOnlyMemory`1 buffer, Boolean completeWrites, CancellationToken cancellationToken) in /_/src/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs:line 431
client-1  |    at System.Net.Http.Http3RequestStream.ReadResponseContentAsync(HttpResponseMessage response, Memory`1 buffer, CancellationToken cancellationToken) in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 1175
client-1  |    at System.Net.Http.Http3RequestStream.WriteRequestContentAsync(ReadOnlyMemory`1 buffer, CancellationToken cancellationToken) in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 482
client-1  |    at HttpStress.ClientOperations.ByteAtATimeNoLengthContent.SerializeToStreamAsync(Stream stream, TransportContext context) in C:\app\ClientOperations.cs:line 615
client-1  |    at System.Net.Http.HttpContent.<CopyToAsync>g__WaitAsync|56_0(ValueTask copyTask) in /_/src/libraries/System.Net.Http/src/System/Net/Http/HttpContent.cs:line 399

It mixes read and write path together.

rzikm · 2024-05-15T16:08:38Z

/azp list

azure-pipelines · 2024-05-15T16:08:44Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-staging runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-android-grpc-client-tests runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-tools-tests runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional runtime-ioslike-coreclr runtime-ioslike-mono runtime-nativeaot-outerloop

rzikm · 2024-05-15T16:09:21Z

/azp run runtime-libraries stress-http

azure-pipelines · 2024-05-15T16:09:31Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2024-05-15T16:20:59Z

Nevermind, spoke too soon, the other callstack in #102202 is much clearer. and the console log from the run shows that we closed the connection from our side, which explains why we would get the OperationAborted error.

rzikm · 2024-05-15T16:25:15Z

/azp run runtime-libraries stress-http

azure-pipelines · 2024-05-15T16:25:24Z

Azure Pipelines successfully started running 1 pipeline(s).

rzikm · 2024-05-20T09:43:25Z

@dotnet/ncl can I get review on this?

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs

* Check for HttpRequestError.HttpProtocolError when expecting HTTP3 protocol errors in test * WIP * Fix data race in ServerClosesOutboundControlStream_ClientClosesConnection * Handle more exceptions explicitly in Http3RequestStream * WIP * Remove debug guard * Fix dotnet#102202

rzikm added 5 commits April 15, 2024 17:34

Check for HttpRequestError.HttpProtocolError when expecting HTTP3 pro…

d5a57a9

…tocol errors in test

WIP

16be6cb

Fix data race in ServerClosesOutboundControlStream_ClientClosesConnec…

89e5cae

…tion

Handle more exceptions explicitly in Http3RequestStream

0eb8069

WIP

3e440e5

ghost added the area-System.Net.Http label May 6, 2024

dotnet-policy-service bot assigned rzikm May 6, 2024

rzikm added the NO-REVIEW Experimental/testing PR, do NOT review it label May 6, 2024

Remove debug guard

dbfa163

rzikm removed the NO-REVIEW Experimental/testing PR, do NOT review it label May 15, 2024

rzikm requested a review from a team May 15, 2024 15:51

Fix dotnet#102202

768b28e

MihaZupan approved these changes May 21, 2024

View reviewed changes

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs Show resolved Hide resolved

MihaZupan added this to the 9.0.0 milestone May 21, 2024

rzikm merged commit cb9b9f7 into dotnet:main May 21, 2024

github-actions bot locked and limited conversation to collaborators Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle missing HTTP3 error cases#101923

Handle missing HTTP3 error cases#101923
rzikm merged 7 commits intodotnet:mainfrom
rzikm:89097-HttpRequestError-Handle-HTTP3-cases-better-if-needed

rzikm commented May 6, 2024 •

edited

Loading

Uh oh!

rzikm commented May 6, 2024

Uh oh!

azure-pipelines bot commented May 6, 2024

Uh oh!

ManickaP commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

azure-pipelines bot commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

azure-pipelines bot commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

azure-pipelines bot commented May 15, 2024

Uh oh!

rzikm commented May 20, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rzikm commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rzikm commented May 6, 2024

Uh oh!

azure-pipelines bot commented May 6, 2024

Uh oh!

ManickaP commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

azure-pipelines bot commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

azure-pipelines bot commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

rzikm commented May 15, 2024

Uh oh!

azure-pipelines bot commented May 15, 2024

Uh oh!

rzikm commented May 20, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rzikm commented May 6, 2024 •

edited

Loading