Skip to content

[browser] dont trim fail fast message #101056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 3 commits into from
Apr 16, 2024
Merged

[browser] dont trim fail fast message #101056

pavelsavara merged 3 commits into from
Apr 16, 2024

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 15, 2024

  • don't trim Environment.FailFast message - because it's on heap not a constant
  • call mono_wasm_print_thread_dump on the thread with onAbort

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm labels Apr 15, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 15, 2024
@pavelsavara pavelsavara self-assigned this Apr 15, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 15, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara requested a review from maraf April 15, 2024 14:55
@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 15, 2024

/ba-g filled new issue for #101072

@build-analysis build-analysis bot mentioned this pull request Apr 15, 2024
Closed
@maraf
Copy link
Member

maraf commented Apr 15, 2024

How much data is it? Should it be configurable?

@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 15, 2024

How much data is it?

guessing 40 bytes more

Should it be configurable?

no

This was referenced Apr 15, 2024
Closed
Closed
Closed
@maraf
Copy link
Member

maraf commented Apr 16, 2024 •
edited
Loading

40 bytes is good 😊
I didn't realized managed messages are not affected by the change

@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 16, 2024

The CI issues are #100628 and #101100

@pavelsavara pavelsavara merged commit 55e3c59 into dotnet:main Apr 16, 2024
@pavelsavara pavelsavara deleted the browser_dont_trim_fail_fast branch April 16, 2024 10:19
@pavelsavara pavelsavara mentioned this pull request Apr 22, 2024
Closed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @matouskozak
[browser] dont trim fail fast message (dotnet#101056)
078508d
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @maraf