Skip to content

[browser] Fix debugger support in WasmAppBuilder #100675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maraf merged 18 commits into from
May 31, 2024
Merged

[browser] Fix debugger support in WasmAppBuilder #100675

maraf merged 18 commits into from
May 31, 2024

Conversation

@maraf
Copy link
Member

@maraf maraf commented Apr 5, 2024 •
edited
Loading

  • Fix regression from [browser] Fix debugger support #97213 for WasmAppBuilder SDK (used by runtime and wasmconsole template)
  • The same defaults were missing in this SDK
  • Add the same WBT as for Wasm SDK

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Apr 5, 2024
@maraf maraf added this to the 9.0.0 milestone Apr 5, 2024
@maraf maraf self-assigned this Apr 5, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 5, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 5, 2024
Closed
Closed
Closed
@dotnet-policy-service dotnet-policy-service bot removed this from the 9.0.0 milestone May 11, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented May 11, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

maraf added 2 commits May 15, 2024 13:50
@maraf
Merge remote-tracking branch 'upstream/main' into BrowserDebuggerSupp…
28964d9 
…ortAppBuilder

# Conflicts:
#	src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs
#	src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs
#	src/tasks/WasmAppBuilder/WasmAppBuilder.cs
@maraf
Abstract test and do a WAB tests
4fae095
@maraf maraf reopened this May 15, 2024
@build-analysis build-analysis bot mentioned this pull request May 15, 2024
Closed
This was referenced May 16, 2024
Closed
Open
@build-analysis build-analysis bot mentioned this pull request May 17, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request May 22, 2024
Open
@build-analysis build-analysis bot mentioned this pull request May 28, 2024
Closed
@maraf maraf force-pushed the BrowserDebuggerSupportAppBuilder branch from 998402d to aa9e854 Compare May 29, 2024 13:06
@maraf maraf closed this May 29, 2024
@maraf maraf reopened this May 29, 2024
@maraf
Copy link
Member Author

maraf commented May 29, 2024

/azp run runtime

@azure-pipelines
Copy link

azure-pipelines bot commented May 29, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request May 29, 2024
Closed
@maraf maraf requested review from ilonatommy and pavelsavara May 30, 2024 16:02
@maraf maraf marked this pull request as ready for review May 30, 2024 16:03
@maraf maraf requested a review from akoeplinger as a code owner May 30, 2024 16:03
ilonatommy
ilonatommy approved these changes May 31, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request May 31, 2024
Closed
This was referenced May 31, 2024
Closed
Closed
@maraf maraf merged commit f190f34 into dotnet:main May 31, 2024
@maraf maraf deleted the BrowserDebuggerSupportAppBuilder branch May 31, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf @ilonatommy