Extend ConfigurationProvider with Source property and Dispose sources when root is Disposed #100642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Note regarding the |
adamsitnik
commented
Apr 4, 2024
|
|
||
| if (Source.OwnsFileProvider) | ||
| { | ||
| (Source.FileProvider as IDisposable)?.Dispose(); |
Member
Author
There was a problem hiding this comment.
Provider.Dispose does not need to dispose the source anymore, the caller can access ConfigurationSource and do it when needed
adamsitnik
commented
Apr 4, 2024
|
|
||
| foreach (IConfigurationSource source in _sources) | ||
| { | ||
| (source as IDisposable)?.Dispose(); |
Member
Author
There was a problem hiding this comment.
the manager has all the sources, so it can just iterate over them and dispose when possible
adamsitnik
commented
Apr 4, 2024
| // dispose providers and the sources | ||
| foreach (IConfigurationProvider provider in _providers) | ||
| { | ||
| (provider.ConfigurationSource as IDisposable)?.Dispose(); |
Member
Author
There was a problem hiding this comment.
the root has no reference sources, but it can now access provider.ConfigurationSource and dispose when possible
This was referenced Apr 4, 2024
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative for #100641 to fix #95745. It requires new public APIs and is a breaking change. Please see my comments