Remove DAM annotations from enum converter#100347
Merged
LakshanF merged 6 commits intodotnet:mainfrom Apr 5, 2024
Merged
Conversation
ghost
added
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel |
This was referenced Mar 27, 2024
sbomer
approved these changes
Mar 29, 2024
Member
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
LGTM but I'd appreciate if @MichalStrehovsky could take a look too.
MichalStrehovsky
requested changes
Apr 1, 2024
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Apr 2, 2024
...tem.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Apr 4, 2024
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Show resolved
Hide resolved
steveharter
reviewed
Apr 4, 2024
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Show resolved
Hide resolved
MichalStrehovsky
approved these changes
Apr 4, 2024
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks good from trimming perspective. Can't talk about TypeConverter or why we accept System.Enum (and whether this should accept all non-enums for the same reasons it accepts System.Enum).
| public EnumConverter([DynamicallyAccessedMembers(TypeDescriptor.ReflectTypesDynamicallyAccessedMembers)] Type type) | ||
| public EnumConverter(Type type) | ||
| { | ||
| if (!type.IsEnum && !type.Equals(typeof(Enum))) |
Member
There was a problem hiding this comment.
I'm a little bit concerned we have tests where this is used with a non-enum and it apparently works (System.Enum is really no different from just System.Object, or whatever).
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Remove DAM annotations from enum converter * expand the debug assert for enum types * FB * FB2
ericstj
added
the
breaking-change
Member
|
Seems there are a few others who might be broken by this: https://github.com/search?q=%2Fbase%5C%28type%5C.GetType%5C%28%5C%29%5C%29%2F+EnumConverter&type=code |
ericstj
added
the
needs-breaking-change-doc-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove DAM annotations from Enum converter since the trimmer always preserve
enums.