Fix Int128 checked-convert to signed IntX#100342
Merged
tannergooding merged 2 commits intodotnet:mainfrom Apr 4, 2024
Merged
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
dotnet-policy-service
bot
added
the
community-contribution
Contributor
Author
|
Feedback addressed. |
This was referenced Mar 27, 2024
tannergooding
approved these changes
Apr 4, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Fix Int128 checked-convert to signed IntX * Simplify implementation
Member
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10256789331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #99489
Hope to add more tests for
Int128in the future.