Skip to content

Fix running tests with process isolation under naot #100331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 13 commits into from
Apr 23, 2024
Merged

Fix running tests with process isolation under naot #100331

MichalStrehovsky merged 13 commits into from
Apr 23, 2024

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Mar 27, 2024

We don't currently run any RequiresProcessIsolation tests under native AOT because we hit the "not an applicable OS" early out here:

runtime/src/tests/Common/CoreCLRTestLibrary/OutOfProcessTest.cs

Lines 75 to 79 in 765ca4e

if (!File.Exists(testExecutable))
{
// Skip platform-specific test when running on the excluded platform
return;
}

Cc @dotnet/ilc-contrib

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Mar 27, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky MichalStrehovsky mentioned this pull request Mar 27, 2024
Merged
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Mar 27, 2024

This fixes things locally. It doesn't fix them in Helix. The reason is that we don't pack the necessary tests into the helix workitem payload (it only has the EXE that is supposed to look for .sh/.cmd files to execute, but there's no .sh/.cmd and the relevant EXEs). This will take a while to untangle.

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 11, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 12, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Apr 15, 2024
@MichalStrehovsky
Ensure Array.CreateInstance for reference types works
d1705b7 
Follow up to dotnet#100626. The original fix only worked for unoptimized builds because the list of templates doesn't survive from scanning phase (when we do dataflow) to codegen phase (when we no longer do dataflow).

The test that this was supposed to fix is still failing in dotnet#100331.
@MichalStrehovsky MichalStrehovsky mentioned this pull request Apr 15, 2024
Merged
MichalStrehovsky added a commit that referenced this pull request Apr 16, 2024
@MichalStrehovsky
Ensure Array.CreateInstance for reference types works (#101048)
5a6560a 
Follow up to #100626. The original fix only worked for unoptimized builds because the list of templates doesn't survive from scanning phase (when we do dataflow) to codegen phase (when we no longer do dataflow).

The test that this was supposed to fix is still failing in #100331.
@agocke
Copy link
Member

agocke commented Apr 16, 2024

@jkoritzinsky for review

@MichalStrehovsky MichalStrehovsky mentioned this pull request Apr 17, 2024
Closed
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 18, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 18, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky MichalStrehovsky mentioned this pull request Apr 19, 2024
Closed
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 19, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 19, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky MichalStrehovsky mentioned this pull request Apr 22, 2024
Closed
5 tasks
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 22, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 22, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 22, 2024
Open
3 tasks
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 22, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 22, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 23, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 23, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Apr 23, 2024

/ba-g mac leg timed out but it's not relevant to what I'm doing here

@MichalStrehovsky MichalStrehovsky merged commit 6e866a6 into dotnet:main Apr 23, 2024
@MichalStrehovsky MichalStrehovsky deleted the mergedrnnr branch April 23, 2024 21:30
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@MichalStrehovsky @matouskozak
Ensure Array.CreateInstance for reference types works (dotnet#101048)
9b7544c 
Follow up to dotnet#100626. The original fix only worked for unoptimized builds because the list of templates doesn't survive from scanning phase (when we do dataflow) to codegen phase (when we no longer do dataflow).

The test that this was supposed to fix is still failing in dotnet#100331.
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@MichalStrehovsky @matouskozak
Fix running tests with process isolation under naot (dotnet#100331)
8ecbf3f 
We don't currently run any RequiresProcessIsolation tests under native AOT because we hit the "not an applicable OS" early out here:

https://github.com/dotnet/runtime/blob/765ca4e9f2dddca2005ffdb45863b7980247a886/src/tests/Common/CoreCLRTestLibrary/OutOfProcessTest.cs#L75-L79
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@MichalStrehovsky @michaelgsharp
Fix running tests with process isolation under naot (dotnet#100331)
fa5b95d 
We don't currently run any RequiresProcessIsolation tests under native AOT because we hit the "not an applicable OS" early out here:

https://github.com/dotnet/runtime/blob/765ca4e9f2dddca2005ffdb45863b7980247a886/src/tests/Common/CoreCLRTestLibrary/OutOfProcessTest.cs#L75-L79
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@MichalStrehovsky MichalStrehovsky

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky @agocke @jkoritzinsky