Synchronized description of destinationDirectoryName parameter#100330
Merged
stephentoub merged 4 commits intodotnet:mainfrom Jul 9, 2024
Merged
Synchronized description of destinationDirectoryName parameter#100330stephentoub merged 4 commits intodotnet:mainfrom
stephentoub merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
dotnet-policy-service
bot
added
the
community-contribution
3 tasks
This was referenced Apr 2, 2024
Contributor
Author
|
Hello! Sorry to bother you guys. Can any of you review this PR? |
carlossanlop
approved these changes
May 13, 2024
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Thank you for your proposed change, @msafwankarim , and thank you for your patience.
src/libraries/System.IO.Compression.ZipFile/src/System/IO/Compression/ZipFile.Extract.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression.ZipFile/src/System/IO/Compression/ZipFile.Extract.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression.ZipFile/src/System/IO/Compression/ZipFile.Extract.cs
Show resolved
Hide resolved
Closed
Contributor
Author
|
Hello @carlossanlop, Thank you for reviewing this PR. It says that "Only those with write acess to this repository can merge pull requests.". Do I need to do something or will it be eventually merged into main at some point? |
matouskozak
added a commit
to matouskozak/runtime
that referenced
this pull request
Jul 11, 2024
…r for all methods (dotnet#100330)" This reverts commit 8d231b4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some overloads of
ExtractToDirectoryhad misleading description for destinationDirectoryName as stated in issue #95501.I have synchronised description of destinationDirectoryName parameter for all
ZipFile.ExtractToDirectorymethods with correct onesThis PR fixes the issue #95501 ZipFile.ExtractToDirectory doc comments wrongly claim that the directory must not exist