-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Description
Description
The automated dependency update PR from runtime to aspnetcore is currently failing: dotnet/aspnetcore#54055
Two tests are failing:
WebApplicationBuilder_EnablesServiceScopeValidationByDefaultInDevelopment(https://github.com/dotnet/aspnetcore/blob/9db62024cbe3c3cb28efe372541fc1bdfcdb375e/src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs#L1784)Build_InDevelopment_ConfiguresWithServiceProviderWithScopeValidation(https://github.com/dotnet/aspnetcore/blob/9db62024cbe3c3cb28efe372541fc1bdfcdb375e/src/Components/WebAssembly/WebAssembly/test/Hosting/WebAssemblyHostBuilderTest.cs#L95)
In both cases the failure is of the form "expected an exception to be thrown, but no exception was thrown". Example of failing build: https://github.com/dotnet/aspnetcore/runs/21630956214
I notice that this started after #96254 was merged 2 days ago, and that PR changes the logic around service scope validation. The PR is not meant to affect the behavior (since it's only intended to add caching) but perhaps it does affect the behavior.
Reproduction Steps
Example of failing build: https://github.com/dotnet/aspnetcore/runs/21630956214
Expected behavior
Service scope validation behavior should be unchanged.
Actual behavior
It no longer throws at the same time that it did before.
Regression?
The behavior was correct in commit ad25468, which is the last one we successfully ingested to dotnet/aspnetcore. The change must have happened since then.
Known Workarounds
No response
Configuration
No response
Other information
No response