Skip to content

[wasm] Chrome version bumper improvements #97364

@radical

Description

@radical

Avoid unnecessary Chrome version bump PRs

The ChromeVersions.props file should only be updated when *_ChromeBaseSnapshotUrl or *_V8Version values change, since those are the only ones that affect the version of chrome being used on CI.

Screenshot 2024-01-22 at 23 04 22

It would avoid creating these bump PRs when nothing relevant has changed.

  • This can be done in ./src/tasks/WasmBuildTasks/GetChromeVersions.cs

Other relevant bits:

Investigate why we can't find more snapshot urls

The chrome{,driver} snapshots are used to run tests on CI. And we try to find the latest stable version, and then find the closest snapshot available for that. But lately the task is only resolving the versions but not finding the corresponding snapshots. It does seem to find them every few weeks though.

See

private async Task<(ChromeVersionSpec versionSpec, string baseSnapshotUrl)> FindVersionFromAllJsonAsync()

cc @ilonatommy @akoeplinger

Metadata

Metadata

Assignees

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-monoin-prThere is an active PR which will close this issue when it is merged

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions