-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
arch-wasmWebAssembly architectureWebAssembly architecturearea-Infrastructure-monoin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged
Milestone
Description
Avoid unnecessary Chrome version bump PRs
The ChromeVersions.props file should only be updated when *_ChromeBaseSnapshotUrl or *_V8Version values change, since those are the only ones that affect the version of chrome being used on CI.
It would avoid creating these bump PRs when nothing relevant has changed.
- This can be done in
./src/tasks/WasmBuildTasks/GetChromeVersions.cs
Other relevant bits:
- bump-chrome-version.yml - used to run the github action
Investigate why we can't find more snapshot urls
The chrome{,driver} snapshots are used to run tests on CI. And we try to find the latest stable version, and then find the closest snapshot available for that. But lately the task is only resolving the versions but not finding the corresponding snapshots. It does seem to find them every few weeks though.
See
| private async Task<(ChromeVersionSpec versionSpec, string baseSnapshotUrl)> FindVersionFromAllJsonAsync() |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
arch-wasmWebAssembly architectureWebAssembly architecturearea-Infrastructure-monoin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged
