-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Description
- Define APPLE_HYBRID_GLOBALIZATION symbol for the 3 OSes and use it throughout the implementation instead of defined(TARGET_MACCATALYST) || defined(TARGET_IOS) || defined(TARGET_TVOS) conditions in all files under
https://github.com/dotnet/runtime/tree/main/src/native/libs/System.Globalization.Native -
HybridGlobalizationis supported only on iOS/tvOS/macCatalyst not OSX. RenameIsHybridGlobalizationOnOSX/IsNotHybridGlobalizationOnOSXtoIsHybridGlobalizationOnApplePlatform/IsNotHybridGlobalizationOnApplePlatformhttps://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs#L384. - Remove
IsIcuGlobalizationAndNotHybridproperty -
Check if possible to include"pal_utilities.h"inpal_placeholders.hinstead of defining asserts, look discussion [HybridGlobalization] Include all globalization symbols #96684 (comment)
we shouldn't mix our configs with pal_config.h.in, so we will keep the way it was implemented.
Contributes to #80689