Skip to content

Update trimming tests to use live-built ILLink.Targets logic #88624

@eerhardt

Description

@eerhardt

The trimming tests are not using the current ILLink.Targets logic that comes from the dotnet/runtime repo. This is a left-over of the previous versions when this logic came from the dotnet/linker repo. But it is now contained in dotnet/runtime, so we should be using the current repo version so PRs are validated with the updated logic.

          My understanding is that the `trimmingTests` failing here are using the package version picked up in this PR, based on

<!-- Logic to override the default IlLink tasks that come from the SDK and use the one
we use in dotnet/runtime repo -->
<ItemGroup>
<PackageReference Include="Microsoft.NET.ILLink.Tasks"
Version="{MicrosoftNETILLinkTasksVersion}"
PrivateAssets="all"
IsImplicitlyDefined="true" />
</ItemGroup>

Originally posted by @sbomer in #88245 (comment)

Metadata

Metadata

Assignees

Labels

area-Tools-ILLink.NET linker development as well as trimming analyzers

Type

No type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions