Skip to content

Improve LoggerMessageGenerator incrementality #76119

New issue
New issue
Closed
#124077
Closed
Improve LoggerMessageGenerator incrementality#76119
#124077
Assignees
cincuranetcopilot-swe-agent
Labels
area-Extensions-Loggingin-prThere is an active PR which will close this issue when it is mergedsource-generatorIndicates an issue with a source generator feature
Milestone
11.0.0
@Youssef1313

Description

@Youssef1313
Youssef1313
opened on Sep 24, 2022

Description

runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Roslyn4.0.cs

Lines 34 to 35 in 985eedd

IncrementalValueProvider<(Compilation, ImmutableArray<ClassDeclarationSyntax>)> compilationAndClasses =
context.CompilationProvider.Combine(classDeclarations.Collect());

I think having the Compilation in the generator pipeline will cause it to fully run on every change, so this is losing the benefits of being incremental.

cc @333fred

Reproduction Steps

Expected behavior

Generator pipeline shouldn't have a Compilation or ISymbols, etc.

Actual behavior

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Metadata

Metadata

Assignees

Labels

area-Extensions-Loggingin-prThere is an active PR which will close this issue when it is mergedsource-generatorIndicates an issue with a source generator feature

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions