Skip to content

Review workaround for ProcessEvent when event source is disabled #65938

@jeffhandley

Description

@jeffhandley

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround that was applied to ProcessEvent for when event source is disabled via a feature switch. The comment indicates the "simple fix" should be reconsidered once #43657 is done. That issue has been closed, but it's unclear if this workaround is still necessary.

{
// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
if (!IsSupported)
{

The applied fix should be reconsidered per the comment to determine if a different fix should be made. With the findings we should either apply a different fix, update the comment to reflect it's a permanent fix as-is, or update the code comment to reference this open issue for tracking.

/cc @deeprobin

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions