-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
area-System.Formats.CboruntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner
Description
Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround in place and it's unclear if the backing issue that necessitated the workaround has been resolved.
- The original issue was: Consider adding HalfToInt16Bits and Int16BitsToHalf to BitConverter · Issue #38288 · dotnet/runtime
- The PR that introduced the workaround was: [CBOR] Use System.Half for encoding and decoding half-precision data items by eiriktsarpalis · Pull Request #38466 · dotnet/runtime
runtime/src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/HalfHelpers.cs
Lines 8 to 12 in f04a242
| namespace System.Formats.Cbor | |
| { | |
| // Temporarily implements missing APIs for System.Half | |
| // Remove class once https://github.com/dotnet/runtime/issues/38288 has been addressed | |
| internal static class HalfHelpers |
The workaround should be evaluated to determine if it's still necessary. With the findings, we should either update the code to remove the workaround, or the code comment to reference an open issue for tracking when we can remove the workaround.
/cc @deeprobin
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-System.Formats.CboruntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner