-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Open
Labels
Milestone
Description
Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround in place and it seems the backing issue has been resolved but the workaround remains.
- The original issue was: Bad IBC data causing official build failures · Issue #33303 · dotnet/runtime
- The PR that applied the workaround was: Disable IBC on OSX by jkoritzinsky · Pull Request #43839 · dotnet/runtime
runtime/eng/codeOptimization.targets
Lines 7 to 12 in b37f10a
| <!-- There's an issue causing IBCMerge failures because of mismatched MVIDs | |
| across many of our assemblies on Mac, so disable | |
| IBCMerge optimizations on Mac for now to unblock the offical build. | |
| See issue https://github.com/dotnet/runtime/issues/33303 | |
| --> | |
| <IsEligibleForNgenOptimization Condition="'$(TargetOS)' == 'OSX' or '$(TargetsMobile)' == 'true'">false</IsEligibleForNgenOptimization> |
The workaround should be evaluated to determine if it's still necessary. With the findings, we should either update the code to remove the workaround, or the code comment to reference an open issue for tracking when we can remove the workaround.
/cc @deeprobin
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
No status