-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
area-System.Text.RegularExpressionsdisabled-testThe test is disabled in source code against the issueThe test is disabled in source code against the issue
Milestone
Description
Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a test case that is being skipped, but the referenced issue has been fixed. The PR with the fix indicates that a different approach might have been possible, but the applied fix has been accepted for some time now.
- The original issue was: Regex fails to accept pattern that it probably should. · Issue #24759 · dotnet/runtime
- The PR that applied the fix was: Fix regex scanner for
\c[by danmoseley · Pull Request #26828 · dotnet/corefx
runtime/src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs
Lines 391 to 395 in f04a242
| yield return new object[] { engine, null, @"(cat)(\cz*)(dog)", "asdlkcat\u001adogiwod", RegexOptions.None, new string[] { "cat\u001adog", "cat", "\u001a", "dog" } }; | |
| if (!PlatformDetection.IsNetFramework) // missing fix for https://github.com/dotnet/runtime/issues/24759 | |
| { | |
| yield return new object[] { engine, null, @"(cat)(\c[*)(dog)", "asdlkcat\u001bdogiwod", RegexOptions.None, new string[] { "cat\u001bdog", "cat", "\u001b", "dog" } }; |
The skipped test case should be evaluated to determine if the fix made allows the test to pass. With the findings we should either enable the test case or update the code comment to reference this open issue for tracking.
/cc @deeprobin
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-System.Text.RegularExpressionsdisabled-testThe test is disabled in source code against the issueThe test is disabled in source code against the issue