Skip to content

Review skipped test case for regex scanner with \c[ pattern #65931

@jeffhandley

Description

@jeffhandley

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a test case that is being skipped, but the referenced issue has been fixed. The PR with the fix indicates that a different approach might have been possible, but the applied fix has been accepted for some time now.

yield return new object[] { engine, null, @"(cat)(\cz*)(dog)", "asdlkcat\u001adogiwod", RegexOptions.None, new string[] { "cat\u001adog", "cat", "\u001a", "dog" } };
if (!PlatformDetection.IsNetFramework) // missing fix for https://github.com/dotnet/runtime/issues/24759
{
yield return new object[] { engine, null, @"(cat)(\c[*)(dog)", "asdlkcat\u001bdogiwod", RegexOptions.None, new string[] { "cat\u001bdog", "cat", "\u001b", "dog" } };

The skipped test case should be evaluated to determine if the fix made allows the test to pass. With the findings we should either enable the test case or update the code comment to reference this open issue for tracking.

/cc @deeprobin

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions