Skip to content

Reconsider tracing functionality when EventSource is disabled #65570

New issue
New issue
Open
Open
Reconsider tracing functionality when EventSource is disabled#65570
Labels
area-Tracing-coreclr
Milestone
Future
@deeprobin

Description

@deeprobin
deeprobin
opened on Feb 18, 2022

Follow-up issue for #43657

As described in #63902, it would be good to remove comments and workarounds that have already been fixed.

Would be great if someone would take another look at the following (and whether this can be removed or replaced with something better if necessary).

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs

Lines 40 to 44 in f04a242

{
// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
if (!IsSupported)
{

/area System.Diagnostics.Tracing

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-Tracing-coreclr

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions