Skip to content

[QUIC] Use shared SocketAddress code in QUIC #32068

New issue
New issue
Closed
#66794
Closed
[QUIC] Use shared SocketAddress code in QUIC#32068
#66794
Assignees
rzikm
Labels
area-System.Net.QuicenhancementProduct code improvement that does NOT require public API changes/additions
Milestone
7.0.0
@scalablecory

Description

@scalablecory
scalablecory
opened on Feb 10, 2020

Instead of reimplementing sockaddr serialization, we should use the existing EndPoint -> SocketAddress -> byte[] logic in System.Net.Primitives.

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Internal/MsQuicAddressHelpers.cs

Lines 27 to 31 in 5c6f5b1

internal static SOCKADDR_INET IPEndPointToINet(IPEndPoint endpoint)
{
SOCKADDR_INET socketAddress = default;
byte[] buffer = endpoint.Address.GetAddressBytes();
if (endpoint.Address != IPAddress.Any && endpoint.Address != IPAddress.IPv6Any)

Metadata

Metadata

Assignees

Labels

area-System.Net.QuicenhancementProduct code improvement that does NOT require public API changes/additions

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions